Allow Raphael to work in pages with a Content Security Policy that disallows 'unsafe-eval'. #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so Raphael works in pages with a Content Security Policy that disallows eval.
|
How come |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special case the Clone method to avoid using the Function constructor so Raphael works in pages with a Content Security Policy that disallows eval.
The input to this function is really only ever a function and and array, but unfortunately
typeoforinstanceofchecks here won't work because the arrays will pass the same checks as the functions. Since the only special operation that's performed on the arrays is ajoin, I used that to detect whether to use a constructor or to fallback to a function literal.The rest is just my editor stripping whitespace, which is probably a good thing anyways.